fix: add missing let/const declarations and strict mode to sync-leaderboard.js (#60)#125
Merged
jagdish-15 merged 1 commit intoJun 8, 2026
Conversation
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. A maintainer will review your submission shortly. |
jagdish-15
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
"use strict"directive andletdeclarations to variables inscripts/sync-leaderboard.jsthat were previously assigned without declaration, leaking to the global scope. Without strict mode, these implicit globals can cause silent data corruption (wrong scores, swapped rankings, duplicate entries) when the three parallel processing blocks (daily/weekly/monthly) share state — and no error is thrown.Linked Issue
Fixes #60
Changes Made
"use strict";at the top of the file — makes accidental global assignment an immediate runtime error instead of silent corruptionlettodailyDatadeclaration (line 104)lettopreviousDatadeclaration (line 108)lettoweeklyDatadeclaration (line 157)lettomonthlyDatadeclaration (line 216)Subsequent reassignments of
previousData(lines 161, 220) remain as-is —letallows reassignment within the same function scope.Type of Change
Testing
Verification performed:
node --check scripts/sync-leaderboard.js— Syntax OKnpx prettier --check "frontend/**/*.{html,css,js}" "scripts/**/*.js" "server.js"— All files passChecklist
Screenshots / Screen Recording
N/A — Backend-only change with no UI impact.