fix: improve autoscroll behaviour #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Preview binaries are ready! To test with modules: |
35C4n0r
commented
Oct 19, 2025
| scrollAreaRef.removeEventListener("scrollend", () => isProgrammaticScrollRef.current = false); | ||
|
|
||
| }; | ||
| }, [checkIfAtBottom, scrollAreaRef]); |
Collaborator
Author
There was a problem hiding this comment.
Note for @BrunoQuaresma
The original code also intended the same scroll UX as we do now, unfortunately the scrollAreaRef.addEventListener("scroll", handleScroll); event listener never gets attached since on the initial(and only) run of this useEffect scrollAreaRef.current; turns out out to be null and we return early. Now I have changed the scrollAreaRef to a useState instead of a useRef, which causes this useEffect to run again when the ref is set.
matifali
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autoscroll/follow only kicks in if:
In case when user manually scrolls up, follow is disabled.