chore: Replace OnSnapshot callback with Emitter interface#185
Open
chore: Replace OnSnapshot callback with Emitter interface#185
Conversation
Member
johnstcn
commented
Feb 12, 2026
johnstcn
commented
- Add Emitter interface to screentracker package
- Remove OnSnapshot from PTYConversationConfig, accept Emitter in NewPTY
- Rename EventEmitter methods: EmitMessages, EmitStatus, EmitScreen
- Accept agentType at NewEventEmitter construction instead of per-call
- Update server.go wiring, all tests pass
- Add Emitter interface to screentracker package - Remove OnSnapshot from PTYConversationConfig, accept Emitter in NewPTY - Rename EventEmitter methods: EmitMessages, EmitStatus, EmitScreen - Accept agentType at NewEventEmitter construction instead of per-call - Update server.go wiring, all tests pass
- Add Emitter interface to screentracker package - Remove OnSnapshot from PTYConversationConfig, accept Emitter in NewPTY - Rename EventEmitter methods: EmitMessages, EmitStatus, EmitScreen - Accept agentType at NewEventEmitter construction instead of per-call - Update server.go wiring, all tests pass
|
✅ Preview binaries are ready! To test with modules: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how PTY conversation snapshot updates are propagated by replacing the OnSnapshot callback with a screentracker.Emitter interface, and wires the HTTP API event stream through that interface.
Changes:
- Introduces
screentracker.Emitterand updatesPTYConversationto emit status/messages/screen via the interface. - Refactors
httpapi.EventEmitterto use a functional-options constructor and renames update methods toEmit*. - Updates server wiring and tests to pass an emitter into
st.NewPTY.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/screentracker/conversation.go | Adds the Emitter interface to represent conversation state emission. |
| lib/screentracker/pty_conversation.go | Removes OnSnapshot callback and emits via Emitter; updates NewPTY signature. |
| lib/screentracker/pty_conversation_test.go | Updates tests to pass a stub emitter into NewPTY. |
| lib/httpapi/events.go | Refactors EventEmitter construction to options + renames methods to Emit*. |
| lib/httpapi/server.go | Passes EventEmitter directly to st.NewPTY as an Emitter. |
| lib/httpapi/events_test.go | Updates tests for NewEventEmitter options and Emit* method names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.