chore: clean up mock upstream in integration tests#190
Merged
Conversation
pawbana
force-pushed
the
pb/tests-refactor-mock-upstream
branch
10 times, most recently
from
8dee463 to
6613c36
Compare
pawbana
force-pushed
the
pb/tests-refactor-mock-upstream
branch
from
6613c36 to
ea82069
Compare
dannykopping
approved these changes
Feb 27, 2026
Collaborator
dannykopping
left a comment
dannykopping
left a comment
There was a problem hiding this comment.
I really like this, great improvement @pawbana!
A couple minor points, but otherwise good to go.
Comment on lines
-1250
to
-1254
| require.Contains(t, files, fixtureRequest) | ||
| require.Contains(t, files, fixtureStreamingResponse) | ||
| require.Contains(t, files, fixtureNonStreamingResponse) | ||
| require.Contains(t, files, fixtureStreamingToolResponse) | ||
| require.Contains(t, files, fixtureNonStreamingToolResponse) |
Collaborator
There was a problem hiding this comment.
We're losing the explicit checks here which are probably fine, but might make it hard to reason about when we have a nil request/response.
Contributor
Author
There was a problem hiding this comment.
Contains response checks are are done in MockUpstream.handle method but there is no check for Request.
I'll add Contains check into getter methods. Thanks for catching that.
dannykopping
approved these changes
Feb 27, 2026
Contributor
Author
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MockUpstreamtest helper that mocks AI provider upstream.Updates existing tests to use new
MockUpstreamhelper cleaning up custom mocks per test.