Skip to content

chore: lint fixes part 9#261

Open
pawbana wants to merge 1 commit intopb/coder-lint-fix8from
pb/coder-lint-fix9
Open

chore: lint fixes part 9#261
pawbana wants to merge 1 commit intopb/coder-lint-fix8from
pb/coder-lint-fix9

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026

  • testpackage (27 → 0): converted 7 test files to external test packages; exported GuessClient and GuessSessionID; merged two TestValidateProvider tests into one using NewRequestBridge; replaced
    bridge.mux.ServeHTTP with exported bridge.ServeHTTP; added //nolint:testpackage to 18 test files that heavily test unexported internals
  • noctx (12 → 0): replaced http.NewRequest with http.NewRequestWithContext(t.Context(), ...) in all test files
  • gocritic magic numbers (46 → 0): created internal/testutil/timeout.go with shared constants (WaitLong, WaitMedium, WaitShort, IntervalFast); replaced all magic timeout/interval values across 8 test files
  • gocritic slog.Error (2 → 0): pass .Error() string instead of error value as slog.F field
  • staticcheck SA9003 (1 → 0): added staticcheck to nolint directive on intentional empty recover
  • confusing-naming (1 → 0): renamed openErrorResponse() → openErrBody()
  • paralleltest (24 → 0): added t.Parallel() to top-level test functions and table-driven subtest loops
  • tparallel (4 → 0): added t.Parallel() to missing subtests

Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 10, 2026

@pawbana pawbana marked this pull request as ready for review April 10, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant