fix: handle comma-separated wildcard paths in allow rules#170
Merged
Conversation
rulesengine/rules.go
Outdated
|
|
||
| if len(input) > 0 && input[0] == '*' { | ||
| if len(input) > 1 && input[1] != '/' { | ||
| if len(input) > 1 && isPChar(input[1]) { |
Collaborator
There was a problem hiding this comment.
I think the only valid symbols after * is either / or ,? We can explicitly check for them? But isPChar also looks good.
Contributor
Author
There was a problem hiding this comment.
I think whitespace would be permitted, too. I update this to be more restrictive because we really just need to check for a path segment terminator.
Collaborator
There was a problem hiding this comment.
I think whitespace would be permitted, too. - make sense
evgeniy-scherbina
approved these changes
Feb 17, 2026
The path segment parser rejected `*` followed by `,` (e.g., `path=/api/v1/*,/api/v2/*`) because it only allowed `*` to be followed by `/` or end-of-string. Fix by checking for any valid path segment character, so `*` is valid as a standalone segment whenever the next character is not a valid path character.
zedkipp
force-pushed
the
zedkipp/comma-wildcard-rules
branch
from
13a73a6 to
119cbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was found by @jatcod3r here: #91 (comment)
The path segment parser rejected
*followed by,(e.g.,path=/api/v1/*,/api/v2/*) because it only allowed*to be followed by/or end-of-string. Fix by checking for any valid path segment character, so*is valid as a standalone segment whenever the next character is not a valid path character.