feat(proxy): inject session ID and sequence number headers on matching requests#198
Draft
SasSwart wants to merge 2 commits intosasswart/feat-config-session-correlation-header-injectionfrom
Conversation
Add YAML and CLI configuration surface for session correlation header injection per the Bridge/Boundaries Correlation RFC (FR 2). New configuration options: - --enable-session-correlation / session_correlation_enabled: top-level toggle to disable injection entirely for deployments without AI Bridge in front. - --inject-session-id-on / session_id_inject_targets (YAML): repeatable list of inject targets in "domain=<host> [path=<glob>]" format. - --session-id-header-name / session_id_header_name: configurable header name (default X-Coder-Agent-Firewall-Session-Id). - --sequence-number-header-name / sequence_number_header_name: configurable header name (default X-Coder-Agent-Firewall-Sequence-Number). Config validation ensures that when correlation is enabled at least one inject target is present and header names are non-empty. Parsing validates the domain=... path=... key-value format and rejects unknown keys. This commit adds config and validation only; runtime injection is wired in a follow-up PR.
…g requests When session correlation is enabled and the outgoing request matches a configured inject target, set X-Coder-Agent-Firewall-Session-Id and X-Coder-Agent-Firewall-Sequence-Number headers on the forwarded request. Any values the jailed client may have set are overwritten so the upstream always sees boundary's authoritative session ID and sequence number. The sequence number is pre-allocated before the audit event so both the audit log and the injected header carry the same value. audit.Request gains a SequenceNumber pointer field; when non-nil the socket auditor uses it instead of calling its own counter. New proxy.Config fields: SessionCorrelation, SessionID, SequenceCounter. New Server method: shouldInjectHeaders (domain + optional path glob matching). Tests cover matched domain, unmatched domain, disabled injection, client-supplied header overwrite, path glob matching, and sequence number incrementing.
This was referenced Apr 30, 2026
c24a0fd to
c08f291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Map
RFC: Bridge ↔ Boundaries Correlation
When session correlation is enabled and the outgoing request matches a configured inject target, set
X-Coder-Agent-Firewall-Session-IdandX-Coder-Agent-Firewall-Sequence-Numberheaders on the forwarded request. Any values the jailed client may have set are overwritten so the upstream always sees boundary's authoritative session ID and sequence number.Depends on #197.
Changes
audit/request.go: AddSequenceNumber *uint64field toRequest. When non-nil, the auditor uses this pre-allocated value instead of generating its own, so the audit log and the injected HTTP header carry the same sequence number.audit/socket_auditor.go: Usereq.SequenceNumberwhen present, falling back tos.seq.Next()for backward compatibility.proxy/proxy.go:SessionCorrelation,SessionID,SequenceCountertoConfigandServer.shouldInjectHeaders(host, path)method: matches request host (case-insensitive, port-stripped) and optional path glob against configuredInjectTargets.processHTTPRequestpre-allocates a sequence number from the shared counter and passes it to bothAuditRequestandforwardRequest.forwardRequeststamps both headers on matching requests after copying client headers (overwriting any client-supplied values).proxy/proxy_framework_test.go: AddWithSessionCorrelation,WithSessionID,WithSequenceCountertest options; wire them into the proxyConfig.proxy/proxy_session_correlation_test.go: New test file with six tests:TestSessionCorrelation_MatchedDomain: headers injected on matching domain.TestSessionCorrelation_UnmatchedDomain: headers absent on non-matching domain.TestSessionCorrelation_Disabled: headers absent when correlation is disabled.TestSessionCorrelation_OverwritesClientValue: proxy overwrites spoofed client headers.TestSessionCorrelation_PathMatching: headers injected only when path glob matches.TestSessionCorrelation_SequenceNumberIncrements: sequence numbers increment across requests.Implementation notes
processHTTPRequestvia the sharedSequenceCounter, then threaded through to both the auditor and the header injection site. This guarantees the audit event and the HTTP header always agree on the sequence number for a given request.shouldInjectHeadersstrips the port from the host before comparison and usespath.Matchfor glob matching, consistent with the RFC'spath=/api/v2/aibridge/*syntax.SequenceCounterreference on the proxy is optional (*audit.SequenceCounter). When nil (e.g. in existing tests that don't care about session correlation), no sequence number is allocated and the auditor falls back to its internal counter.Note
This PR was authored by Coder Agents.