chore: add tests on container runtime#2
Merged
DanielleMaywood merged 16 commits intomainfrom Mar 6, 2025
Merged
Conversation
It appears GitHub's hosted runners do not have sysbox-runc available
This implementation isn't the nicest but we only run the tests when CLISTAT_IS_CONTAINERIZED is either 'yes' or 'no'. We have to do this as we do not know whether we are in a container or not at runtime.
matifali
reviewed
Mar 5, 2025
matifali
reviewed
Mar 5, 2025
matifali
reviewed
Mar 5, 2025
johnstcn
reviewed
Mar 6, 2025
matifali
reviewed
Mar 6, 2025
matifali
reviewed
Mar 6, 2025
Having a double negative doesn't make much sense, rework this to instead ensure IsContainerized matches based on if CLISTAT_IS_CONTAINERIZED is true
We still need to be able to compile the tests, it appears 128MB is not enough and the compiler OOMed
johnstcn
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#445
Run the test-suite on a container runtime, as well as add some tests for container-specific behavior.