🤖 chore: abstract parent lookup pattern in cgroupv2 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getFromParentOrDefault generic function to eliminate duplication - Refactor cpuQuota() and memoryMaxBytes() to use helper - Simplify error messages: 'read parent' instead of redundant context
- Rename getFromParentOrDefault to getFromParentOrFallback - Change parameter from defaultValue to fallback function - Apply helper to cpuPeriod, memoryCurrentBytes, memoryInactiveFileBytes - Update function doc comment to reflect fallback function - Standardize inline comments to 'try parent or [action]' pattern The fallback function approach allows handling both default values and error returns, making the abstraction applicable to all parent lookup scenarios. This eliminates 40+ lines of boilerplate across 5 methods.
DanielleMaywood
changed the title
johnstcn
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts a repeating parent lookup pattern in cgroupv2 using a generic helper function. Relates to #28 (comment)
Changes
cpuQuota()cpuPeriod()memoryMaxBytes()memoryCurrentBytes()memoryInactiveFileBytes()🤖 PR was written by Claude Sonnet 4.5 Thinking using Coder Mux and reviewed by a human 👩