-
Notifications
You must be signed in to change notification settings - Fork 12
Use GitHub actions to upload release artifacts #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @oxy - sorry this took so long to address. I spoke to Jon A. about this. He said it mostly looks good. Last thing to do, look over the workflow they use in |
|
Ah, good point. Okay, I'll take a look then! |
|
Oh - signing could be a problem; right now it just produces unsigned builds, and since I don't have access to secrets for this repo, or any Apple devices to test on/work with, I'm not sure how to handle signing. |
No worries at all. I have Apple Devices and access to secrets. I'm going to take a look at this next week and should be able to push the necessary changes |
|
Spoke to @sreya and he said we can skip the Apple signing for now. |
049d3f3 to
82dfc5a
Compare
|
I'll edit this to use |
|
Cleaned up to use a matrix + to use Hopefully should be good for another review @jsjoeio. |
jsjoeio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really clean and way easy to read! Nice work! 🙌
|
I think either you or sreya would have to merge it in - I don't have write access 😅 |
|
Ah gotcha. Okay I'll merge 🤞 |
Whenever a GH release is created/published, this should automatically build
cloud-agentand upload the binaries for linux/macOS amd64/arm64. These are the platforms we currently build for oncode-serverwith the exception ofmacos-arm64, which I'm currently investigating.