## Problem WorkspaceStore had 3 separate manual cache implementations: 1. Per-workspace state cache (Map<string, WorkspaceState>) 2. All-states cache with 16-line O(n) validation logic 3. Recency cache using JSON.stringify for hashing This was fragile, error-prone, and violated DRY principles. ## Changes ### 1. Centralized Caching (Fix #1 - HIGH) - Replaced 3 manual caches with single CacheManager instance - **Removed 58 lines** of manual cache validation logic - Single `cache.invalidateAll()` call in `emit()` - impossible to forget - Consistent with StreamingMessageAggregator pattern ### 2. Extract Recency Computation (Fix #2 - MEDIUM) - Created `src/utils/messages/recency.ts` - **Single array reverse** instead of two - 11 unit tests for edge cases ### 3. Extract Array Comparison (Fix #4 - LOW) - Created `src/utils/arrays.ts` - `arraysEqualByReference()` helper with 11 unit tests - Simplified `statesEqual()` from 34 lines to 10 ### 4. Enhanced Tests (Fix #3 - MEDIUM) - Added cache invalidation tests (4 new tests) - Added race condition tests (3 new tests) - Total: 41 new tests across 3 files ## Impact - **Net: -123 lines** in WorkspaceStore.ts (172 removed, 49 added) - **+502 lines total** (379 lines of new tests) - **All 467 tests pass** (19 WorkspaceStore, 11 recency, 11 arrays) - Zero type/lint errors ## What Wasn't Changed - Did NOT extract message handlers (148-line handleChatMessage) - Would be 4-6 hour effort with high integration risk - Deferred until handlers become more complex Generated with `cmux`

Minor nits #3

Description

Electron

Startup

Code Health

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions