Skip to content

Conversation

@ThomasK33
Copy link
Member

Run make build before playwright to provide dist artifacts when needed.
Gate dist mode behind CMUX_E2E_LOAD_DIST and assert required files.
Skip the dev server and launch electron with production env when set.
Enable parallel playwright workers to keep runtimes acceptable.

@ThomasK33 ThomasK33 force-pushed the thomask33/10-10-enable_dist_e2e_mode branch from 4f92a5c to ccc55b1 Compare October 10, 2025 18:20
@chatgpt-codex-connector
Copy link

💡 Codex Review

expect: {
timeout: 5_000,
},
fullyParallel: true,
forbidOnly: isCI,

P1 Badge Running e2e tests in parallel conflicts with fixed dev server port

Enabling fullyParallel means multiple Playwright workers execute the e2e project simultaneously, but tests/e2e/electronTest.ts still spawns a Vite dev server on the hard‑coded port 5173 for every test. When the suite is run locally without CMUX_E2E_LOAD_DIST=1 (the default today), the second worker tries to start another dev server on the same port and exits immediately, causing nondeterministic failures. Consider keeping the project single‑threaded when the dev server is involved or allocate unique ports per worker.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Run make build before playwright to provide dist artifacts when needed.
Gate dist mode behind CMUX_E2E_LOAD_DIST and assert required files.
Skip the dev server and launch electron with production env when set.
Enable parallel playwright workers to keep runtimes acceptable.
@ThomasK33 ThomasK33 force-pushed the thomask33/10-10-enable_dist_e2e_mode branch from ccc55b1 to 65e4b0c Compare October 10, 2025 18:33
@ThomasK33
Copy link
Member Author

💡 Codex Review

expect: {
timeout: 5_000,
},
fullyParallel: true,
forbidOnly: isCI,

P1 Badge Running e2e tests in parallel conflicts with fixed dev server port
Enabling fullyParallel means multiple Playwright workers execute the e2e project simultaneously, but tests/e2e/electronTest.ts still spawns a Vite dev server on the hard‑coded port 5173 for every test. When the suite is run locally without CMUX_E2E_LOAD_DIST=1 (the default today), the second worker tries to start another dev server on the same port and exits immediately, causing nondeterministic failures. Consider keeping the project single‑threaded when the dev server is involved or allocate unique ports per worker.

ℹ️ About Codex in GitHub

Fixed this

@ThomasK33
Copy link
Member Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@ThomasK33 ThomasK33 added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 1ea9924 Oct 10, 2025
6 of 7 checks passed
@ThomasK33 ThomasK33 deleted the thomask33/10-10-enable_dist_e2e_mode branch October 10, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant