🤖 Fix niceness bash escaping regression #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used JSON.stringify to wrap the command, which converted newlines to literal \n strings, breaking multi-line bash scripts. Now spawn 'nice' directly with proper arguments: nice -n N bash -c "script" This avoids all escaping issues while maintaining the same functionality. Added comprehensive test coverage for: - Complex multi-line scripts with conditionals - Exit code handling with niceness - Simple commands with niceness
ammar-agent
force-pushed
the
fix-bash-nice-regression
branch
from
979ee50 to
83b620c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression introduced in PR #162 where complex multi-line bash scripts with conditionals would fail with exit code 2.
Problem
The original implementation wrapped commands using
JSON.stringify, which converted newlines to literal\nstrings:nice -n 19 bash -c "if [ \0 -ne 0 ]; then\n echo \"test\"\nfi"This broke bash syntax, causing scripts with conditionals and multi-line logic to fail.
Solution
Spawn
nicedirectly with proper arguments array instead of string wrapping:This avoids all escaping issues while maintaining the same niceness functionality.
Testing
Added comprehensive test coverage:
All 36 tests pass including the new niceness test suite.
Generated with
cmux