🤖 Fix intermittent Cmd+Shift+T keybind failure #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toggle thinking keybind (Cmd+Shift+T) would fail in new chats because it checked message history for the current model, which is null until the first message is sent. However, users can see and select a model in the UI immediately (stored in localStorage). Root cause: State source mismatch - UI shows: selectedModel from localStorage (always available) - Keybind checked: currentModel from message history (null in new chats) Fix: Read the selected model from localStorage and fall back to message history model if not set. This matches what the user sees in the UI. Now the keybind works immediately in new chats, matching user expectations. _Generated with `cmux`_
ammario
approved these changes
Oct 15, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
The review bot correctly identified that with empty localStorage (brand new workspace or cleared storage), both selectedModel and currentModel would be null, causing the keybind to still fail. Now uses the same fallback logic as useSendMessageOptions: selectedModel ?? currentModel ?? defaultModel This ensures the keybind always has a model to work with, matching what the UI displays (which also defaults to claude-sonnet-4-5). _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Cmd+Shift+T keybind for toggling thinking would fail in new chats (before any messages were sent). User would press the key and nothing would happen, even though they could see a model selected in the UI.
Root cause: State source mismatch between what the user sees and what the keybind checks:
selectedModelfrom localStorage (always available, shown in bottom-left selector)currentModelfrom message history (null until first message sent)User sees "opus" selected, presses Cmd+Shift+T, nothing happens because the keybind was checking message history instead of the selected model.
Solution
Read the selected model from localStorage (using
getModelKey(workspaceId)) and fall back to message history model if not set:This matches what the user sees in the UI, so the keybind now works immediately in new chats.
Testing
Changes
Generated with
cmux