🤖 Add Ghostty search paths and ban sync fs methods #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add macOS-specific Ghostty detection for Homebrew and app bundle paths - Convert terminal detection to async operations using fs.stat() - Add ESLint rule to prevent synchronous filesystem operations - Check /opt/homebrew/bin/ghostty, /Applications/Ghostty.app, /usr/local/bin Fixes Ghostty detection when not in PATH.
Temporarily exempt files with existing sync fs usage to avoid breaking the build. The rule will still prevent new sync fs usage in other files. Files exempted: - src/config.ts (initialization code) - src/debug/**/*.ts (CLI tools) - src/git.ts, src/main.ts (bootstrap code) - src/services/* (existing services) New code in other locations will be required to use async fs operations.
Ensure Ghostty path detection only matches actual files, not directories with execute permission (which most directories have for traversal).
ammar-agent
force-pushed
the
ghostty-fix
branch
from
069a4dc to
21f0a54
Compare
ammario
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Ghostty detection on macOS when installed via Homebrew or as an app bundle.
Changes
Terminal Detection:
/opt/homebrew/bin/ghostty(Homebrew)/Applications/Ghostty.app/Contents/MacOS/ghostty(App bundle)/usr/local/bin/ghostty(manual install)fs.stat()with executable bit checking (0o111)ESLint Rule:
local/no-sync-fs-methodsrule to ban sync filesystem operationsstatSync,readFileSync,existsSync, etc.Testing
Verify with:
Generated with
cmux