Skip to content

🤖 Update bash sleep error to permit <10s sleeps in busy loops #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2025
Merged

🤖 Update bash sleep error to permit <10s sleeps in busy loops #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/tools/bash.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,8 +894,8 @@ describe("bash tool", () => {

expect(result.success).toBe(false);
if (!result.success) {
expect(result.error).toContain("sleep commands are blocked");
expect(result.error).toContain("polling loops");
expect(result.error).toContain("do not start commands with sleep");
expect(result.error).toContain("prefer <10s sleeps in busy loops");
expect(result.error).toContain("while ! condition");
expect(result.exitCode).toBe(-1);
expect(result.wall_duration_ms).toBe(0);
Expand Down
2 changes: 1 addition & 1 deletion src/services/tools/bash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const createBashTool: ToolFactory = (config: ToolConfiguration) => {
return {
success: false,
error:
"sleep commands are blocked to minimize waiting time. Instead, use polling loops to check conditions repeatedly (e.g., 'while ! condition; do sleep 1; done' or 'until condition; do sleep 1; done').",
"do not start commands with sleep; prefer <10s sleeps in busy loops (e.g., 'while ! condition; do sleep 1; done' or 'until condition; do sleep 1; done').",
exitCode: -1,
wall_duration_ms: 0,
};
Expand Down