🤖 Improve loading workspace UI #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace LoadingIndicator with EmptyState for consistent styling - Loading state now matches 'No Messages Yet' visual style - Add window.__showLoadingWorkspace() debug function to inspect UI - Remove unused LoadingIndicator component
Previous implementation showed welcome screen instead of loading state. Now temporarily removes workspace from store, showing 'Loading workspace...' for 2 seconds before restoring the workspace data.
- Add flex: 1 to EmptyState so it properly fills ViewContainer - Remove __showLoadingWorkspace debug function (too complex to implement correctly) - Loading and empty states now properly centered
ammario
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading workspace state now uses the same centered, styled EmptyState component as 'No Messages Yet' for visual consistency.
Fixed EmptyState to properly center by adding
flex: 1so it fills the ViewContainer.Generated with
cmux