fix: 🤖 Trigger refresh after Track All to update UI state #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After staging untracked files via Track All button, the UI should automatically refresh to reflect the changes (updated hunks, tree, and untracked count). Solution: Pass onRefresh callback from ReviewPanel through ReviewControls to UntrackedStatus. Call it after successful git add operation. This refresh only happens from user action (clicking Track All), preventing infinite loops.
The Code Review panel checkbox was labeled 'Dirty' but actually includes ALL uncommitted changes (staged + unstaged) via git diff HEAD. 'Uncommitted' is more accurate and less ambiguous than 'Dirty'. Breaking change: localStorage keys changed from review-include-dirty to review-include-uncommitted. Users will lose this preference per workspace (acceptable for early development phase). Changes: - Renamed includeDirty → includeUncommitted in types and all components - Updated localStorage key: review-include-dirty → review-include-uncommitted - Updated UI label: 'Dirty' → 'Uncommitted' - Updated comments to reference 'uncommitted changes'
Fixed three potential race conditions: 1. **Optimistic update race**: Removed setUntrackedFiles([]) call before onRefresh(). Now refresh reloads from git, avoiding flicker if git index hasn't flushed yet. 2. **Concurrent load race**: Added loadingRef to prevent multiple simultaneous git ls-files commands when refreshTrigger changes rapidly. 3. **hasLoadedOnce persistence**: This ref already resets per-workspace via workspaceId dependency, so no fix needed here. The refresh now correctly happens AFTER git add completes successfully, and the UI updates are sourced from the subsequent git query rather than optimistic local state.
ammario
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #318 (untracked files feature). Includes two improvements:
1. Trigger refresh after Track All
After staging untracked files via Track All button, the UI should automatically refresh to reflect the changes (updated hunks, tree, and untracked count).
Implementation:
onRefreshcallback from ReviewPanel through ReviewControls to UntrackedStatusonRefresh()after successfulgit addoperation in Track All handler2. Rename 'Dirty' to 'Uncommitted' for clarity
The checkbox was labeled "Dirty" but actually includes ALL uncommitted changes (staged + unstaged) via
git diff HEAD. "Uncommitted" is more accurate and less ambiguous.Breaking change: localStorage keys changed from
review-include-dirtytoreview-include-uncommitted. Users will lose this preference per workspace (acceptable for early development phase).Testing
Generated with
cmux