🤖 Cmd+2 returns focus to Review tab #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user presses Cmd+2 (or Ctrl+2 on Windows/Linux) while already viewing the Code Review tab, the keybind now focuses the panel and selects the first hunk for easier keyboard navigation. Implementation uses a simple prop trigger pattern: - RightSidebar maintains focusTrigger counter state - Incrementing the counter triggers ReviewPanel to focus first hunk - Declarative approach avoids forwardRef/useImperativeHandle complexity This makes keyboard-driven code review workflows smoother - users can quickly jump to the first hunk without needing to click or use j/k navigation from an arbitrary scroll position.
ammar-agent
force-pushed
the
cmd-tab-keybinds
branch
from
ab51173 to
d69d442
Compare
Changed Cmd+2 behavior when already on Review tab to only focus the panel without modifying the selected hunk. This preserves user's position in the review and allows keyboard navigation to resume from where they left off.
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pressing Cmd+2 (Ctrl+2 on Windows/Linux) while already on the Code Review tab now returns keyboard focus to the panel, enabling immediate keyboard navigation without clicking.
Implementation
Uses a simple prop trigger pattern:
RightSidebarincrementsfocusTriggercounter when Cmd+2 is pressed on active Review tabReviewPanelwatches trigger and calls.focus()on panel refBehavior
Why This Matters
Code review with keyboard is faster when you can instantly return focus from chat input to the review panel. Previously, you had to click on the panel or tab through UI elements.
Generated with
cmux