🤖 Harden auto-continue idempotency: requestId guard + backend dedupe #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable - Add requestId to compaction-result metadata (source compaction-request user msg) - WorkspaceStore: dedupe performCompaction by compaction-request id - Hook: guard on requestId (fallback to summary message id) - Fix retry cleanup to remove the right id from the processed set Generated with cmux
ammar-agent
force-pushed
the
fix-compact-continue-race-messageid
branch
from
f0542be to
b4225ce
Compare
…o behavior change. The workspaceStatesRef was written but never read.\nThis reduces cognitive load and avoids confusion during future edits.\n\nGenerated with cmux
Generated with cmux
ammario
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why another fix?
Message-ID guard reduced duplicates but users still observed rare double-sends.
Root cause in those cases: two distinct summary messages were created for
one compaction-run (different IDs) due to duplicated completion signals
(delete + message + final bump, reconnect/replay, or abort/accept flows).
What changed
Why this is obviously correct
Testing notes
_Generated with _