🤖 Fix auto-scroll and TODO flickering #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use double RAF in performAutoScroll to ensure scroll happens after async content (like DiffRenderer highlighting) finishes rendering. First frame allows DOM updates, second frame scrolls after layout.
Only update currentTodos reference when content actually changes. Prevents PinnedTodoList from flickering when todo_write is called with identical content.
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-scroll issue: FileEditToolCall's DiffRenderer shows "Processing..." while highlighting, then expands after auto-scroll runs.
Fix: Double RAF ensures scroll happens after async content finishes rendering.
TODO flickering issue: created new array reference even when content identical.
Fix: Deep equality check in StreamingMessageAggregator prevents unnecessary reference changes.
Generated with
cmux