🤖 Fix web server error handling to preserve structured errors #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web server was converting structured SendMessageError objects (like
api_key_not_found) into plain strings, causing the UI to display
'Unknown Error' instead of helpful messages with solutions.
Changes:
- Server now passes through Result<T, E> types as-is instead of
unwrapping and stringifying error objects
- Browser API updated to handle Result types correctly
- Added unit tests for error toast creation
Before: 'Message Send Failed - Unknown Error'
After: 'API Key Not Found - The openai provider requires an API key'
with solution: '/providers set openai apiKey YOUR_API_KEY'
Generated with `cmux`
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Server now only passes through Result types when they fail (have structured
errors). Successful Results and normal return values are wrapped, allowing
the browser API to unwrap all successful responses consistently.
This fixes the issue where providers.list() was receiving { success: true,
data: [...] } instead of just [...], while still preserving structured
errors like api_key_not_found for proper UI display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using cmux in web mode and encountering API key errors, the UI displays "Message Send Failed - Unknown Error" instead of the proper error message with solutions.
Server logs show the correct error:
But the UI receives "Unknown Error" because the server was stringifying structured errors.
Solution
The server's IPC adapter was checking if errors were strings and converting objects to "Unknown error". Updated to pass through Result<T, E> types as-is, preserving the full structure including discriminated union types like
api_key_not_found.Browser API now correctly handles Result types and returns them without modification.
Testing
createErrorToastcovering all error typesGenerated with
cmux