🤖 Add image attachment button for mobile #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add attach button (📎) positioned in bottom-right of input area - Hidden file input with accept='image/*' and multiple selection - Clicking button opens native file picker - Reuses existing processImageFiles logic for consistent handling - Button disabled when chat input is disabled
Hide the attach button on desktop (>768px width) since desktop users can paste or drag-and-drop images. Mobile users need the button to access the file picker.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Remove absolute positioning from attach button - Make it a flex sibling of VimTextArea instead - Add flex-shrink: 0 to maintain button size - Button now sits beside the input instead of overlaying it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a file picker button for attaching images on mobile devices.
Changes
accept='image/*'and multiple selection supportprocessImageFileslogic for consistent image handlingWhy
Desktop users can paste images, but mobile devices need a button to open the file picker. This provides a consistent cross-platform experience for image attachments.
The button is always visible (on mobile and desktop) since it provides a convenient alternative to paste/drag-and-drop.
Generated with
cmux