🤖 Use stable timestamps and version for visual testing #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Replace Date.now() with stable timestamp in all story files - Mock VERSION in Storybook with stable values for Chromatic - Use Apple's iconic demo time: January 24, 2024, 9:41 AM PST - Ensures consistent visual snapshots across Chromatic runs
kylecarbs
force-pushed
the
tailwind-story-ignore
branch
from
f5c9931 to
eea24f8
Compare
Add fixedTipIndex prop to TipsCarousel to override automatic rotation in Storybook stories, ensuring consistent visual snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces dynamic timestamps with Apple's iconic demo time (January 24, 2024, 9:41 AM PST) and mocks VERSION in Storybook to ensure consistent visual snapshots in Chromatic.
Changes
Date.now().storybook/mocks/version.tsto provide stable version infoTitleBar.stories.tsxto test version displayWhy
Chromatic visual regression tests were failing due to:
Now all visual tests use stable, predictable values.
Generated with
cmux