🤖 Migrate markdown rendering to streamdown #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace react-markdown with streamdown, a drop-in replacement optimized for AI streaming - Replace rehype-sanitize with rehype-harden for improved security - Add streamdown source path to Tailwind v4 config for proper styling - Enable parseIncompleteMarkdown for better handling of streaming content - Update plugin configuration to match streamdown's API (typed Pluggable arrays) - Remove old dependencies: react-markdown, rehype-sanitize Streamdown provides the same functionality with additional features: - Better handling of incomplete/unterminated markdown blocks during streaming - Built-in security with rehype-harden - Optimized for AI-powered content streaming - Full compatibility with our existing custom components and styling
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move rehype-harden after rehypeRaw to ensure all HTML is sanitized. Previously, harden ran before rehypeRaw, allowing unsanitized HTML to be injected after the security check.
Override streamdown's default 'space-y-4' className to prevent extra vertical padding on markdown content. We handle spacing at the component level in MarkdownRenderer/TypewriterMarkdown.
Use space-y-0 instead of empty string to properly override streamdown's default space-y-4 wrapper spacing.
Explicitly set margin-top: 0 on streamdown's block children to prevent double-spacing. Our paragraph/heading margins already provide appropriate spacing between elements.
- Change message content padding from p-3 to px-3 (horizontal only) - Remove CSS override that was fighting streamdown's spacing - Use streamdown's default space-y-4 wrapper for proper block spacing - Apply MarkdownRenderer to user messages for consistent formatting This allows streamdown's block spacing (space-y-4) to provide vertical spacing while px-3 provides horizontal padding, eliminating the double-spacing issue.
- Change content wrapper from p-3/px-3 to m-3 (margin instead of padding) - Revert UserMessage to use <pre> tags (not markdown) This prevents double-spacing when streamdown's space-y-4 adds margin-top to blocks. Margins collapse, padding doesn't.
Use space-y-2 instead of the default space-y-4 to reduce excessive vertical spacing between markdown blocks.
Remove .markdown-content p margin rule - streamdown's space-y-2 wrapper provides sufficient spacing between blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
react-markdownwithstreamdown, a drop-in replacement specifically designed for streaming AI content.Changes
react-markdownwithstreamdowninMarkdownCore.tsxrehype-sanitizewithrehype-hardenfor improved securityglobals.css)Pluggable[]arrays matching streamdown's APIparseIncompleteMarkdownfor better handling of incomplete markdown blocks during AI streamingreact-markdownandrehype-sanitizedependenciesBenefits
Streamdown provides enhanced functionality while maintaining full compatibility:
rehype-hardenwith safe defaults for link/image prefixesreact-markdownAll existing custom components (code highlighting with Shiki, Mermaid diagrams, custom styling) work without changes.
Testing
make typecheck)make test)make build)Generated with
cmux