🤖 Deduplicate test infrastructure and copy-to-clipboard logic #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
rt-test-dedup
branch
from
ad7d172 to
b137e16
Compare
After the SSH runtime commit (#178), testing infrastructure had significant duplication across helper modules and inline functions. Changes: - Consolidated shared utilities into tests/ipcMain/helpers.ts - Added extractTextFromEvents(), sendMessageAndWait(), createWorkspaceWithInit() - Centralized test constants (INIT_HOOK_WAIT_MS, SSH_INIT_WAIT_MS, HAIKU_MODEL, etc.) - Deleted tests/ipcMain/test-helpers/runtimeTestHelpers.ts (149 lines) - Removed inline helper duplicates from test files - runtimeFileEditing.test.ts: -120 lines - removeWorkspace.test.ts: -39 lines - renameWorkspace.test.ts: -45 lines - runtimeExecuteBash.test.ts: simplified imports Result: 240 net lines removed, improved consistency across integration tests. All tests use consistent patterns from single source of truth.
The copy feedback pattern (copied state + 2000ms timeout) was duplicated across 4 components with identical implementations. Changes: - Created src/hooks/useCopyToClipboard.ts hook for reusable copy functionality - Added COPY_FEEDBACK_DURATION_MS constant to src/constants/ui.ts (2000ms) - Updated components to use the hook: - AssistantMessage: -11 lines - UserMessage: -18 lines (also removed useState import) - ProposePlanToolCall: -12 lines - FileEditToolCall: -13 lines Result: 54 lines of duplicated code replaced with single 33-line hook. Single source of truth for copy feedback duration and implementation.
ammar-agent
force-pushed
the
rt-test-dedup
branch
from
b137e16 to
ff3f401
Compare
ammario
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the SSH runtime commit (#178, commit 5f200a6), there was significant duplication in test infrastructure and repeated copy-to-clipboard patterns across components.
Test Infrastructure Consolidation
Consolidated 3 overlapping test helper modules and inline duplicates into
tests/ipcMain/helpers.ts:extractTextFromEvents(),sendMessageAndWait(),createWorkspaceWithInit()tests/ipcMain/test-helpers/runtimeTestHelpers.ts(149 lines)Result: -240 lines, single source of truth for ipcMain integration test utilities.
Copy-to-Clipboard Deduplication
The copy feedback pattern (
copiedstate + 2000ms timeout) was duplicated across 4 components with identical implementations.src/hooks/useCopyToClipboard.tsfor reusable copy functionalityCOPY_FEEDBACK_DURATION_MSconstant tosrc/constants/ui.tsResult: 54 lines of duplicated code replaced with single 33-line hook.
Generated with
cmux