Skip to content

🤖 fix: make temp directory cleanup non-blocking for faster stream interruption #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

🤖 fix: make temp directory cleanup non-blocking for faster stream interruption #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/services/streamManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,19 +978,22 @@ export class StreamManager extends EventEmitter {
streamInfo.partialWriteTimer = undefined;
}

// Clean up stream temp directory using runtime
// Clean up stream temp directory using runtime (fire-and-forget)
// Don't block stream completion waiting for directory deletion
// This is especially important for SSH where rm -rf can take 500ms-2s
if (streamInfo.runtimeTempDir) {
try {
const result = await streamInfo.runtime.exec(`rm -rf "${streamInfo.runtimeTempDir}"`, {
void streamInfo.runtime
.exec(`rm -rf "${streamInfo.runtimeTempDir}"`, {
cwd: "~",
timeout: 10,
})
.then(async (result) => {
await result.exitCode;
log.debug(`Cleaned up temp dir: ${streamInfo.runtimeTempDir}`);
})
.catch((error) => {
log.error(`Failed to cleanup temp dir ${streamInfo.runtimeTempDir}:`, error);
});
await result.exitCode; // Wait for completion
log.debug(`Cleaned up temp dir: ${streamInfo.runtimeTempDir}`);
} catch (error) {
log.error(`Failed to cleanup temp dir ${streamInfo.runtimeTempDir}:`, error);
// Don't throw - cleanup is best-effort
}
}

this.workspaceStreams.delete(workspaceId);
Expand Down