🤖 Fix symlink preservation when editing files #464
Merged
+115
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a file through a symlink, both LocalRuntime and SSHRuntime were replacing the symlink with a regular file instead of writing through it to preserve the link. SSHRuntime now uses 'cat temp > target' instead of 'mv temp target' to write through symlinks. LocalRuntime resolves symlinks with fs.realpath() before writing to the actual target. Added integration test that verifies symlinks are preserved when editing files through them in both local and SSH runtimes.
ammario
approved these changes
Oct 28, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Use readlink -f to resolve symlinks first, then mv the temp file to the resolved path. This maintains atomicity (readers see old or new file, never partial) while preserving symlinks. Addresses Codex review feedback.
Both LocalRuntime and SSHRuntime now preserve the original file permissions when editing through symlinks. If the target file exists, its permissions are read before writing and restored after. For new files, default permissions apply (600 for SSH, system defaults for local). Added integration test verifying permissions are preserved across edits.
ammario
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a file through a symlink, both
LocalRuntimeandSSHRuntimewere replacing the symlink with a regular file instead of writing through it.Changes
SSHRuntime: Changed from
mv temp targettocat temp > target && rm tempwhich writes through symlinks naturally.LocalRuntime: Added
fs.realpath()resolution to write to the actual target file instead of replacing the symlink.Testing
Added integration test verifying symlinks are preserved when editing files through them. All 90 runtime integration tests pass.
Generated with
cmux