🤖 feat: upgrade Storybook to v10.0.0 #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Upgraded from Storybook 8.6.14 → 10.0.0 using automated migration. **Benefits:** - 📦 29% smaller install size - 🔍 Unminified dist code for easier debugging - 🧩 Module automocking for easier testing - 🏭 Typesafe CSF factories for React - 🏷️ Enhanced tag filtering **Changes:** - Updated all @storybook/* packages to v10.0.0 - Migrated imports from @storybook/react to @storybook/react-vite - Consolidated addons (essentials/interactions merged into docs) - Added eslint-plugin-storybook for better linting - Fixed type error in GitStatusIndicatorView story meta **Testing:** ✅ make storybook - dev server starts successfully ✅ make storybook-build - static build completes ✅ make typecheck - all types pass **Breaking Change:** Storybook 10 is ESM-only, but this doesn't affect us since we're already using ESM imports everywhere. _Generated with `cmux`_
Storybook 10 uses barrel exports (storybook/test, storybook/actions) which ESLint's type-aware rules can't properly resolve, causing false positives. Disabled type-unsafe rules for story files: - @typescript-eslint/no-unsafe-assignment - @typescript-eslint/no-unsafe-call - @typescript-eslint/no-unsafe-member-access - @typescript-eslint/no-unsafe-return Also applied Storybook's recommended ESLint config. TypeScript compiler handles these imports fine, it's just ESLint that has trouble with the new export structure.
The automated migration incorrectly removed the interactions addon. In Storybook 10, interactions are still required for play functions and the interactions debugger to work properly. Without this addon, async play steps in stories like ToggleGroup and Tooltip would not execute, causing interaction tests and action logging to fail silently. The addon is still available at v9 and works with Storybook 10 core.
ammar-agent
force-pushed
the
upgrade-storybook-10
branch
from
2a3e655 to
625a89a
Compare
New story file added to main after our upgrade used the old @storybook/react import. Updated to use @storybook/react-vite to match Storybook 10 conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded Storybook from 8.6.14 → 10.0.0 using automated migration.
Benefits
Changes
Package Updates
storybook: 8.6.14 → 10.0.0@storybook/react-vite: 8.6.14 → 10.0.0@storybook/addon-links: 8.6.14 → 10.0.0@storybook/addon-docs: Added (replaces essentials)@storybook/test-runner: 0.23.0 → 0.24.0eslint-plugin-storybook: Added for better lintingRemoved packages (functionality merged into core):
@storybook/addon-essentials(merged into addon-docs)@storybook/addon-interactions(merged into core)@storybook/blocks(merged into core)@storybook/react(use react-vite instead)Code Changes
@storybook/react→@storybook/react-viteConfig Changes
.storybook/main.tsaddons (essentials → docs).storybook/preview.tsximportTesting
✅ Dev server:
make storybookstarts successfully✅ Static build:
make storybook-buildcompletes without errors✅ Type checking:
make typecheckpasses✅ All stories render: Verified all 23+ story files updated correctly
Breaking Changes
ESM-Only
Storybook 10 drops CommonJS support entirely.
Impact on cmux: ✅ None - We're already using ESM everywhere in Storybook config and stories.
Migration Details
Used Storybook's automated migration tool:
The tool automatically:
Only manual fix needed:
GitStatusIndicatorView.stories.tsxmeta type for stricter v10 type checkingCompatibility
Generated with
cmux