🤖 fix: truncate status_set messages at 60 chars instead of failing #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add STATUS_MESSAGE_MAX_LENGTH constant (60 chars) - Remove Zod max validation, add truncation logic - Messages >60 chars truncated to 59 chars + ellipsis - Update tests for truncation behavior No more validation errors for long status messages.
ammario
changed the title
ammario
approved these changes
Oct 29, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex correctly identified that the UI was reading status_set message from tool input instead of output, bypassing truncation. Now reads from the tool result to get the truncated message. Added test to verify truncation propagates to UI status display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
status_settool previously validated message length at 40 characters via Zod schema, causing tool failures when agents provided longer messages. This changes the behavior to gracefully truncate at 60 characters with an ellipsis.Changes:
STATUS_MESSAGE_MAX_LENGTHconstant (60 chars) totoolLimits.ts.max(40)Zod validation from schematruncateMessage()helper that truncates to 59 chars + "…"Behavior:
This eliminates validation errors for long status messages while maintaining a reasonable display limit.
Generated with
cmux