Skip to content

🤖 fix: use shell script for artifact name instead of replace() #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

🤖 fix: use shell script for artifact name instead of replace() #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions .github/workflows/terminal-bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,24 @@ jobs:
ls -la runs/
fi

- name: Set artifact name
if: always()
id: artifact-name
run: |
if [ -n "${{ inputs.model_name }}" ]; then
# Replace colons with hyphens for filesystem compatibility
ARTIFACT_NAME="terminal-bench-results-$(echo "${{ inputs.model_name }}-${{ github.run_id }}" | tr ':' '-')"
else
ARTIFACT_NAME="terminal-bench-results-${{ github.run_id }}"
fi
echo "name=$ARTIFACT_NAME" >> $GITHUB_OUTPUT
echo "Artifact name: $ARTIFACT_NAME"

- name: Upload benchmark results
if: always()
uses: actions/upload-artifact@v4
with:
# Replace colons with hyphens to avoid GitHub artifact name restrictions
name: terminal-bench-results-${{ inputs.model_name && replace(format('{0}-{1}', inputs.model_name, github.run_id), ':', '-') || format('{0}', github.run_id) }}
name: ${{ steps.artifact-name.outputs.name }}
path: |
runs/
if-no-files-found: warn
Expand Down