🤖 feat: add URL parameter to status_set tool #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional url parameter to status_set tool definition - Update backend to handle and return URL in results - Store URL in StreamingMessageAggregator with agent status - Make emoji clickable when URL present, opens in new tab - Display URL in status tooltip below message - Add comprehensive tests for URL parameter handling - URL persists until replaced by new status (no-op if same URL) Generated with `cmux`
Previously, calling status_set without a URL would clear the stored URL. Now, the URL persists until explicitly replaced with a different URL. - Updated StreamingMessageAggregator to preserve previous URL - Updated test to verify URL persistence behavior - Clarified tool description
Introduced lastStatusUrl field to track the most recent URL set via status_set, ensuring it persists even when agentStatus is cleared by new user messages. - URL now persists across stream boundaries until explicitly replaced - Added TDD test to verify URL persistence after status clear - All 15 status tests passing This ensures the URL remains available throughout a conversation, even when status is cleared between user/assistant turns.
ammar-agent
force-pushed
the
feat-status-url
branch
from
82730f1 to
62e8dc6
Compare
Instead of inline type assertion, import and use the StatusSetToolResult type with Extract utility type to ensure consistency with the actual tool result type definition.
Moved StatusSetToolResult type definition from services to src/types/tools.ts to avoid frontend importing from services layer. This maintains proper architectural boundaries where frontend code (utils/messages, stores) can import types without importing service implementations. - Added url field to StatusSetToolArgs and StatusSetToolResult in types - Updated status_set service to import type from @/types/tools - Updated StreamingMessageAggregator to import from @/types/tools - All tests passing, architectural boundaries respected
Added comment explaining why src/utils/** and src/stores/** are not included in the frontend services import restriction. These directories have legitimate reasons to import from services (tool registry) or are safe when using type-only imports (which now come from src/types/).
ammario
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional URL parameter to
status_settool for linking to external resources (e.g., Pull Request URLs).When URL is provided:
Generated with
cmux