🤖 fix: increase stream timeouts in CI to handle rate limits #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests were timing out in CI due to: - API rate limiting causing slower response times - CI environment overhead - Tests using 15s/25s timeouts insufficient for file operations Changes: - Add CI detection to increase timeouts by 2.5x in CI environments - STREAM_TIMEOUT_LOCAL_MS: 15s → 37.5s in CI - STREAM_TIMEOUT_SSH_MS: 25s → 62.5s in CI - waitForStreamSuccess default: 30s → 75s in CI Fixes flakes in: - tests/ipcMain/runtimeFileEditing.test.ts - tests/ipcMain/sendMessage.test.ts (anthropic provider tests) - tests/ipcMain/sendMessage.test.ts (image support test)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The previous commit added CI-aware timeout constants but tests were still passing hardcoded values (10s, 30s) directly to waitForStreamSuccess, bypassing the CI multiplier. Changes: - Export STREAM_TIMEOUT_SHORT_MS (10s → 25s in CI) - Export STREAM_TIMEOUT_MEDIUM_MS (30s → 75s in CI) - Replace all hardcoded timeouts in sendMessage.test.ts with constants This ensures all flaky tests get the CI timeout multiplier: - Anthropic provider tests (was 10s, now 25s in CI) - OpenAI provider tests (was 30s, now 75s in CI) - Image support tests (was 30s, now 75s in CI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests from PR #513 were flaking in CI due to stream timeouts:
tests/ipcMain/runtimeFileEditing.test.ts- File creation timed out after 15stests/ipcMain/sendMessage.test.ts- Multiple Anthropic provider tests timed out after 30stests/ipcMain/sendMessage.test.ts- Image support test timed outCI logs show tests that passed took 10-258 seconds total, while failing tests hit the 15-30s stream timeouts. The issue is exacerbated by:
Solution
Make stream timeouts CI-aware with 2.5x multiplier for CI environments:
STREAM_TIMEOUT_LOCAL_MS: 15s → 37.5s in CISTREAM_TIMEOUT_SSH_MS: 25s → 62.5s in CIwaitForStreamSuccessdefault: 30s → 75s in CICI detection uses standard
process.env.CIcheck. Local development keeps existing faster timeouts for quick feedback.Testing
The failing tests already have Jest retry logic (
jest.retryTimes(2-3)) which will validate the fix across multiple attempts if needed. Extended timeouts give API calls breathing room without slowing down successful runs (streams still end immediately on completion).Generated with
cmux