🤖 feat: add aria-labels to ProjectSidebar and fix path text cutoff #524
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add aria-label to project items, workspace lists, and buttons - Add role=region to workspace list containers - Fix vertical text cutoff by changing leading-none to leading-tight - Improves screen reader accessibility throughout the sidebar
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ibetitsmike
pushed a commit
that referenced
this pull request
Nov 7, 2025
) Added aria-labels to ProjectSidebar components for better screen reader support and fixed vertical text clipping in path displays. ## Changes **Accessibility improvements:** - Added `aria-label` to project expand/collapse buttons - Added `role="region"` with descriptive labels to workspace list containers - Added `aria-label` to workspace selection buttons - Added `aria-label` to sidebar collapse/expand button **Text rendering fix:** Changed `leading-none` to `leading-tight` in path displays (both drag preview and sidebar). The `leading-none` style set line-height to 1, which caused vertical text clipping with certain characters, particularly those with descenders or accents. _Generated with `cmux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aria-labels to ProjectSidebar components for better screen reader support and fixed vertical text clipping in path displays.
Changes
Accessibility improvements:
aria-labelto project expand/collapse buttonsrole="region"with descriptive labels to workspace list containersaria-labelto workspace selection buttonsaria-labelto sidebar collapse/expand buttonText rendering fix:
Changed
leading-nonetoleading-tightin path displays (both drag preview and sidebar). Theleading-nonestyle set line-height to 1, which caused vertical text clipping with certain characters, particularly those with descenders or accents.Generated with
cmux