Skip to content

Conversation

@sr229
Copy link
Contributor

@sr229 sr229 commented Sep 30, 2019

Following the requests over in GH-35, we'll be doing ARM distributions by leveraging the existing CI we have.

Do not merge until coder/nbin#23 is finished.

sr229 and others added 4 commits September 21, 2019 03:37
This is the same PR but with some fixes for v2.

Co-Authored-by: nwtnsqrd <noreply@github.com>
Signed-off-by: Ayane Satomi <chinodesuuu@gmail.com>
Signed-off-by: Ayane Satomi <sr229@coder.com>
they will be seperate images from now on.

Signed-off-by: Ayane Satomi <sr229@coder.com>
@sr229 sr229 added complex enhancement Some improvement that isn't a feature labels Sep 30, 2019
@sr229 sr229 self-assigned this Sep 30, 2019
we might be doing something really bad by not putting it on the same rules as Alpine ARM

Signed-off-by: Ayane Satomi <sr229@coder.com>
if [[ "${target}" == "linux" ]] ; then
image="codercom/nbin-centos"
fi
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless whitespace

}

main "$@"
main "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line

@sr229
Copy link
Contributor Author

sr229 commented Oct 21, 2019

Closing in favor of new PR

@sr229 sr229 closed this Oct 21, 2019
@sr229 sr229 deleted the sr229/arm branch October 21, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Some improvement that isn't a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants