Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 27, 2021

Bumps @types/node from 12.20.10 to 15.0.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot requested a review from a team as a code owner April 27, 2021 16:08
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #3241 (e4c2398) into main (1e683f3) will not change coverage.
The diff coverage is n/a.

❗ Current head e4c2398 differs from pull request most recent head d6ebe5a. Consider uploading reports for the commit d6ebe5a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3241   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e683f3...d6ebe5a. Read the comment docs.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 27, 2021

lol @jawnsy you'll laugh at this

I thought we disabled updates for @types/node here: https://github.com/cdr/code-server/blob/main/.github/dependabot.yml#L18-L20

Maybe we have to explicitly set "15.x"?

Copy link

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao, we'll just keep trying until we can make it work 🕺

"@types/http-proxy": "^1.17.4",
"@types/js-yaml": "^4.0.0",
"@types/node": "~12.20.7",
"@types/node": "~15.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jsjoeio jsjoeio self-assigned this Apr 27, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 27, 2021

Closing in favor of #3244

@jsjoeio jsjoeio closed this Apr 27, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 27, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/types/node-15.0.1 branch April 27, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants