Fixes issue #7544 which adding a cookie-suffix flag #7590
Merged
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes coder#7544 but is it the best way?
code-asher
reviewed
Dec 6, 2025
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Sorry it took so long to review this. I like the direction we are headed!
…to set the set the cookie-suffix via environment variable or inline flag
code-asher
approved these changes
Dec 12, 2025
src/common/http.ts
Outdated
| export enum CookieKeys { | ||
| Session = "code-server-session", | ||
| export function getCookieSessionName(suffix?: string): string { | ||
| return suffix ? `code-server-session-${suffix.replace(/[^a-zA-Z0-9\-]/g, "-")}` : "code-server-session"; |
Member
There was a problem hiding this comment.
Ooo right good catch on the alphanumeric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
cookie-suffixflag and environment variable. This adds the possibility for the user to fix the issue but the default option would still be the same (Best for backwards compatibility).This PR does fix the issue #7544 where a subdomain would not use the right cookie because of the wildcard cookie set by a domain of higher order.