chore(installer): remove WinHttpAutoProxySvc service dependency#168
Open
deansheather wants to merge 1 commit into
Open
chore(installer): remove WinHttpAutoProxySvc service dependency#168deansheather wants to merge 1 commit into
deansheather wants to merge 1 commit into
Conversation
Our Tailscale fork patches out the WPAD requirement (see coder/tailscale#118), so the Coder Desktop service no longer needs to depend on the WinHTTP Web Proxy Auto-Discovery Service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
WinHttpAutoProxySvc(WinHTTP Web Proxy Auto-Discovery) service dependency from the Coder Desktop system service.In our Tailscale fork, we've patched out the requirement on WPAD (see coder/tailscale#118), so this dependency is no longer necessary.
The service now only depends on
netprofm(Network List Service).