_

Author: aslilac

coderd/database/dbmem/dbmem.go

@@ -6463,7 +6463,7 @@ func (q *FakeQuerier) UpdateUserStatus(_ context.Context, arg database.UpdateUse
 	return database.User{}, sql.ErrNoRows
 }
 
-func (q *FakeQuerier) UpdateUserThemePreference(ctx context.Context, arg database.UpdateUserThemePreferenceParams) (database.User, error) {
+func (q *FakeQuerier) UpdateUserThemePreference(_ context.Context, arg database.UpdateUserThemePreferenceParams) (database.User, error) {
 	err := validateDatabaseType(arg)
 	if err != nil {
 		return database.User{}, err

site/src/components/RequireAuth/RequireAuth.tsx

@@ -9,7 +9,7 @@ import { DashboardProvider } from "../Dashboard/DashboardProvider";
 import { FullScreenLoader } from "../Loader/FullScreenLoader";
 
 export const RequireAuth: FC = () => {
-  const { signOut, isSigningOut, isSignedOut } = useAuth();
+  const { signOut, isSigningOut, isSignedOut, isLoading } = useAuth();
   const location = useLocation();
   const isHomePage = location.pathname === "/";
   const navigateTo = isHomePage
@@ -37,21 +37,23 @@ export const RequireAuth: FC = () => {
     };
   }, [signOut]);
 
+  if (isLoading || isSigningOut) {
+    return <FullScreenLoader />;
+  }
+
   if (isSignedOut) {
     return (
       <Navigate to={navigateTo} state={{ isRedirect: !isHomePage }} replace />
     );
-  } else if (isSigningOut) {
-    return <FullScreenLoader />;
-  } else {
-    // Authenticated pages have access to some contexts for knowing enabled experiments
-    // and where to route workspace connections.
-    return (
-      <DashboardProvider>
-        <ProxyProvider>
-          <Outlet />
-        </ProxyProvider>
-      </DashboardProvider>
-    );
   }
+
+  // Authenticated pages have access to some contexts for knowing enabled experiments
+  // and where to route workspace connections.
+  return (
+    <DashboardProvider>
+      <ProxyProvider>
+        <Outlet />
+      </ProxyProvider>
+    </DashboardProvider>
+  );
 };

site/src/contexts/AuthProvider/AuthProvider.tsx

@@ -1,3 +1,11 @@
+import {
+  createContext,
+  type FC,
+  type PropsWithChildren,
+  useCallback,
+  useContext,
+} from "react";
+import { useMutation, useQuery, useQueryClient } from "react-query";
 import { checkAuthorization } from "api/queries/authCheck";
 import {
   authMethods,
@@ -7,25 +15,17 @@ import {
   me,
   updateProfile as updateProfileOptions,
 } from "api/queries/users";
-import {
+import { isApiError } from "api/errors";
+import type {
   AuthMethods,
   UpdateUserProfileRequest,
   User,
 } from "api/typesGenerated";
-import {
-  createContext,
-  FC,
-  PropsWithChildren,
-  useCallback,
-  useContext,
-} from "react";
-import { useMutation, useQuery, useQueryClient } from "react-query";
-import { permissionsToCheck, Permissions } from "./permissions";
 import { displaySuccess } from "components/GlobalSnackbar/utils";
-import { FullScreenLoader } from "components/Loader/FullScreenLoader";
-import { isApiError } from "api/errors";
+import { permissionsToCheck, type Permissions } from "./permissions";
 
 type AuthContextValue = {
+  isLoading: boolean;
   isSignedOut: boolean;
   isSigningOut: boolean;
   isConfiguringTheFirstUser: boolean;
@@ -88,21 +88,24 @@ export const AuthProvider: FC<PropsWithChildren> = ({ children }) => {
     logoutMutation.mutate();
   }, [logoutMutation]);
 
-  const signIn = async (email: string, password: string) => {
-    await loginMutation.mutateAsync({ email, password });
-  };
-
-  const updateProfile = (req: UpdateUserProfileRequest) => {
-    updateProfileMutation.mutate(req);
-  };
+  const signIn = useCallback(
+    async (email: string, password: string) => {
+      await loginMutation.mutateAsync({ email, password });
+    },
+    [loginMutation],
+  );
 
-  if (isLoading) {
-    return null;
-  }
+  const updateProfile = useCallback(
+    (req: UpdateUserProfileRequest) => {
+      updateProfileMutation.mutate(req);
+    },
+    [updateProfileMutation],
+  );
 
   return (
     <AuthContext.Provider
       value={{
+        isLoading,
         isSignedOut,
         isSigningOut,
         isConfiguringTheFirstUser,

site/src/pages/LoginPage/LoginPage.tsx

@@ -33,38 +33,41 @@ export const LoginPage: FC = () => {
         const redirectURL = new URL(redirectTo);
         if (redirectURL.host !== window.location.host) {
           window.location.href = redirectTo;
-          return <></>;
+          return null;
         }
       } catch {
         // Do nothing
       }
       // Path based apps.
       if (redirectTo.includes("/apps/")) {
         window.location.href = redirectTo;
-        return <></>;
+        return null;
       }
     }
+
     return <Navigate to={redirectTo} replace />;
-  } else if (isConfiguringTheFirstUser) {
+  }
+
+  if (isConfiguringTheFirstUser) {
     return <Navigate to="/setup" replace />;
-  } else {
-    return (
-      <>
-        <Helmet>
-          <title>Sign in to {applicationName}</title>
-        </Helmet>
-        <LoginPageView
-          authMethods={authMethods}
-          error={signInError}
-          isSigningIn={isSigningIn}
-          onSignIn={async ({ email, password }) => {
-            await signIn(email, password);
-            navigate("/");
-          }}
-        />
-      </>
-    );
   }
+
+  return (
+    <>
+      <Helmet>
+        <title>Sign in to {applicationName}</title>
+      </Helmet>
+      <LoginPageView
+        authMethods={authMethods}
+        error={signInError}
+        isSigningIn={isSigningIn}
+        onSignIn={async ({ email, password }) => {
+          await signIn(email, password);
+          navigate("/");
+        }}
+      />
+    </>
+  );
 };
 
 export default LoginPage;

site/src/pages/UserSettingsPage/AppearancePage/AppearancePage.tsx

@@ -19,12 +19,7 @@ export const AppearancePage: FC = () => {
           isLoading={updateThemePreferenceMutation.isLoading}
           error={updateThemePreferenceMutation.error}
           initialValues={{ theme_preference: me.theme_preference }}
-          onSubmit={async (arg: any) => {
-            console.log("going");
-            const x = await updateThemePreferenceMutation.mutateAsync(arg);
-            console.log(x);
-            return x;
-          }}
+          onSubmit={updateThemePreferenceMutation.mutateAsync}
         />
       </Section>
     </>