fix: fix TestCloserStack_Timeout to wait for all asyncClosers

[spikecurtis]

fixes coder/internal#966

TestCloserStack_Timeout creates asyncClosers which allow control over the exact timing and order of their close method returning. They also, as a final backstop will throw an error if the test context ends before they are unblocked.

TestCloserStack_Timeout unblocks all asyncClosers in a defer and then ends the test. This defer unblocks the running close goroutines, but does not wait for them to finish. Since the test context is canceled as soon as the test completes, this creates a race condition where the close goroutines can trigger the context cancelled arm of the select statement.

The fix is to both unblock and wait for all close goroutines to complete before ending the test and cancelling the context.

[spikecurtis]

• fix: fix TestCloserStack_Timeout to wait for all asyncClosers #19837 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.