Skip to content

fix: avoid connection logging crashes in agent [2.26] #20306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix: avoid connection logging crashes in agent [2.26] #20306

merged 1 commit into from
Oct 15, 2025

Conversation

deansheather
Copy link
Member

For release 2.26

  • Ignore errors when reporting a connection from the server, just log them instead
  • Translate connection log IP localhost to 127.0.0.1 on both the server and the agent
  • Temporary fix: convert invalid IPs to 127.0.0.1 since the database forbids NULL

Relates to #20194

@deansheather deansheather requested a review from mafredri October 15, 2025 13:47
@deansheather deansheather requested a review from Emyrk October 15, 2025 13:49
@deansheather deansheather changed the title fix: avoid connection logging crashes in agent fix: avoid connection logging crashes in agent [2.26] Oct 15, 2025
@deansheather deansheather merged commit 03440f6 into release/2.26 Oct 15, 2025
35 checks passed
@deansheather deansheather deleted the dean/connlog-fix-2.26 branch October 15, 2025 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Emyrk Emyrk Emyrk approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@deansheather deansheather

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deansheather @Emyrk