fix: centralize warning message in static error #20389
Conversation
BrunoQuaresma
requested review from
a team and
Parkreiner
and removed request for
a team
site/static/error.html
Outdated
| </div> | ||
| </body> | ||
|
|
||
| <head> |
There was a problem hiding this comment.
the prettier code style is that <head> and <body> both should be indented
site/static/error.html
Outdated
|
|
||
| p, | ||
| li { | ||
| color: rgb(161, 161, 170); |
There was a problem hiding this comment.
this should still be a hex color
site/static/error.html
Outdated
| p, | ||
| li { | ||
| color: rgb(161, 161, 170); | ||
| line-height: 22.4px; |
There was a problem hiding this comment.
22.4px is a specific enough value to deserve a rationale comment. why not a percent anymore? why not 22px?
site/static/error.html
Outdated
| padding-top: 10px; | ||
| margin-left: 30px; | ||
| font-size: 14px; | ||
| line-height: 25.6px; |
There was a problem hiding this comment.
another very odd line-height choice
site/static/error.html
Outdated
| } | ||
|
|
||
| .warning li { | ||
| text-align: left; |
There was a problem hiding this comment.
where is the center align coming from? manually left aligning things that should just be left aligned feels like a bit of a bandaid
site/static/error.html
Outdated
| background: rgb(13, 19, 33); | ||
| width: 100%; | ||
| padding: 24px; | ||
| text-align: left; |
|
Not sure what I did to cause this diff 😓 I only changed a few lines, but it looks like something else got picked up too. |
site/static/error.html
Outdated
| This template is used by application handlers to render friendly error pages | ||
| when there is a proxy error (for example, when the target app isn't running). | ||
|
|
||
| Since it is served from subdomains, both on proxies and the primary, it MUST | ||
| NOT access any external resources. It must be entirely self-contained. This | ||
| includes anything in `/static` or `/icon`, as these are not served from | ||
| subdomains. | ||
| Since it is served from subdomains, both on proxies and the primary, it MUST | ||
| NOT access any external resources. It must be entirely self-contained. This | ||
| includes anything in `/static` or `/icon`, as these are not served from | ||
| subdomains. |
There was a problem hiding this comment.
maybe re-indent this comment if that also wasn't intentional?
site/static/error.html
Outdated
| font-size: 24px; | ||
| margin-bottom: 8px; | ||
| font-weight: 400; | ||
| color: #FFF; |
There was a problem hiding this comment.
nit: for #fff and #000 I like to just use white and black as it's slightly faster to read
2 participants
Before:
After:
Fixes #20369