feat(coderd): add task prompt modification endpoint #20811

DanielleMaywood · 2025-11-18T00:01:31Z

This PR adds the backend implementation for modifying task prompts. Part of coder/internal#1084

Changes

New UpdateTaskPrompt database query to update task prompts
New PATCH /api/v2/tasks/{task}/prompt endpoint

Notes

This is part 1 of a 2-part PR stack. The frontend UI will be added in a follow-up PR based on this branch (#20812).

🤖 PR was written by Claude Sonnet 4.5 Thinking using Coder Mux and reviewed by a human 👩

This adds a new PATCH endpoint to modify the prompt of an existing task and restart its build. This is the backend implementation including: - New UpdateTaskPrompt database query - New PATCH /api/v2/tasks/{task}/prompt endpoint - Authorization checks for task modification - Database changes to support prompt updates - Generated API documentation and TypeScript types

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

coderd/aitasks.go

coderd/database/queries/tasks.sql

coderd/aitasks.go

mafredri · 2025-11-18T14:28:13Z

coderd/aitasks.go

+		return
+	}
+
+	if req.Prompt == "" {


I could see this as a use-case, set the prompt to empty for e.g. next start.

Can remove this then

Could you elaborate that use-case? 🤔 I'm not clear on what the agent would do with an empty prompt on next start

It looks like you need to fill something into the prompt in the UI too, so I’m fine with leaving the check. @ssncferreira my thought was that you might want to start up the task in idle state so that you can interact with agentapi directly, e.g. upload attachments, etc. But you can just as well type ”do nothing” as prompt to achieve that so aligning with UI is fine.

coderd/aitasks.go

mafredri · 2025-11-18T14:38:41Z

coderd/aitasks.go

+// @Tags Experimental
+// @Param user path string true "Username, user ID, or 'me' for the authenticated user"
+// @Param task path string true "Task ID" format(uuid)
+// @Param request body codersdk.UpdateTaskPromptRequest true "Update task prompt request"


Our terminology is becoming a bit inconsistent here, first you create a task with input, but then update prompt which replaces the input/prompt.

Would you prefer renaming prompt to input here? Happy to do so

Let's go with input to stay consistent 👍🏻

ssncferreira · 2025-11-18T16:26:18Z

coderd/aitasks.go

+		return
+	}
+
+	if req.Prompt == "" {


Could you elaborate that use-case? 🤔 I'm not clear on what the agent would do with an empty prompt on next start

ssncferreira · 2025-11-18T16:28:36Z

coderd/aitasks.go

+		// Block updates if:
+		// 1. Job is actively running (pending, running, canceling)
+		// 2. Workspace is running (job succeeded with start transition)
+		if job.JobStatus == database.ProvisionerJobStatusPending ||


Why are we disallowing prompt update on job pending? In this state, the provisioner hasn't even picked up the workspace build job yet, so it should be safe to update the prompt, correct?

coderd/aitasks.go

ssncferreira

LGTM ✅
Just some nits, but nothing blocking 🙂

ssncferreira · 2025-11-20T12:56:41Z

coderd/aitasks.go

+			})
+		}
+
+		if task.Status == database.TaskStatusInitializing || task.Status == database.TaskStatusActive {


So this leaves us with: "pending,paused,unknown,error"...should we allow changes on unknown and error?

I'm still happy with removing this entirely but this allows us to change on Unknown and Error. The task status is considered Error when you cancel the workspace build, which is what needs to be done to stop it before it starts executing.

As for unknown, I'm on the fence and can be convinced either way on that.

Error could also mean the app is unhealthy. I guess a bigger question is. If a workspace is initializing or active, how is this API intended to be used? Do we cancel the current transition, run a stop transition on the workspace, update the prompt, then start it again?

In this scenario, one could see paused as the only acceptable state where prompt can be updated?

Oh should I also run a stop transition after the cancel? 👀 My plan was to just cancel the transition (hence why I allow changing on error), update the prompt, and run a start transition again.

@mafredri I've updated the PR and it only allows updating the input when the task is paused.

@DanielleMaywood it's safest to run a stop transition because otherwise there isn't a guarantee the workspace will be in a valid state afterwards.

I think there's another issue related to this that I can't find right now, but the discussion here should give at least some context: #8266

coderd/aitasks_test.go

ssncferreira · 2025-11-20T13:14:13Z

coderd/database/queries/tasks.sql

+
+
+-- name: UpdateTaskPrompt :one
+UPDATE


nit: I understand that the task status is computed from the view tasks_with_status, so this might not be trivial, but should we change the query to only update the task's prompt if the task is in an allowed status? Otherwise, maybe just adding a comment that we should only update a task's prompt if it is in status 'pending', 'paused', 'unknown', or 'error' (i.e., NOT 'initializing' or 'active').

coderd/aitasks_test.go

ssncferreira · 2025-11-20T13:20:29Z

Also, just a note on the Chromatic CI failed test: OrganizationSidebarView. This was already fixed by #20808

mafredri

The main blocker is still the task.Status check IMO, it's feels like somewhat arbitrary enforcement due to some states having multiple potential causes. Like error could be failed build or unhealthy app (potentially running task, just agentapi failing health check).

Some minor additional feedback inline.

coderd/database/modelqueries_internal_test.go

codersdk/aitasks.go

mafredri · 2025-11-24T13:48:50Z

coderd/aitasks.go

+			})
+		}
+
+		if task.Status == database.TaskStatusInitializing || task.Status == database.TaskStatusActive {


Error could also mean the app is unhealthy. I guess a bigger question is. If a workspace is initializing or active, how is this API intended to be used? Do we cancel the current transition, run a stop transition on the workspace, update the prompt, then start it again?

In this scenario, one could see paused as the only acceptable state where prompt can be updated?

coderd/aitasks_test.go

mafredri

DanielleMaywood mentioned this pull request Nov 18, 2025

feat(site): allow modifying task prompts for starting tasks #20812

Open

github-actions bot assigned DanielleMaywood Nov 18, 2025

DanielleMaywood marked this pull request as draft November 18, 2025 00:02

DanielleMaywood changed the title ~~feat(tasks): add task prompt modification endpoint~~ feat(coderd): add task prompt modification endpoint Nov 18, 2025

chatgpt-codex-connector bot reviewed Nov 18, 2025

View reviewed changes

coderd/aitasks.go Outdated Show resolved Hide resolved

DanielleMaywood marked this pull request as ready for review November 18, 2025 10:33

DanielleMaywood requested review from mafredri and ssncferreira November 18, 2025 10:35

mafredri reviewed Nov 18, 2025

View reviewed changes

ssncferreira reviewed Nov 18, 2025

View reviewed changes

DanielleMaywood added 3 commits November 18, 2025 17:05

chore: listen to feedback

94453b4

chore: oops

b8d3c21

chore: feedback again

9c82a1f

ssncferreira approved these changes Nov 20, 2025

View reviewed changes

DanielleMaywood added 3 commits November 20, 2025 13:41

chore: address feedback

feb5cc7

Merge branch 'main' into danielle-change-task-prompt-backend

b12f12f

Merge branch 'main' into danielle-change-task-prompt-backend

36b8c78

DanielleMaywood requested a review from mafredri November 24, 2025 13:35

mafredri reviewed Nov 24, 2025

View reviewed changes

DanielleMaywood added 5 commits November 24, 2025 13:59

chore: remove jank comment, workspace -> task

d370e3c

chore: prompt -> input

f9749f6

chore: move tests into table

fbeb95c

chore: oops

a0e0efd

chore: gate on task being paused

3c7204c

mafredri approved these changes Nov 25, 2025

View reviewed changes

DanielleMaywood merged commit 82f525b into main Nov 25, 2025
35 checks passed

DanielleMaywood deleted the danielle-change-task-prompt-backend branch November 25, 2025 11:13

github-actions bot locked and limited conversation to collaborators Nov 25, 2025

feat(coderd): add task prompt modification endpoint #20811

feat(coderd): add task prompt modification endpoint #20811

Conversation

DanielleMaywood commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mafredri Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ssncferreira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ssncferreira commented Nov 20, 2025

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mafredri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DanielleMaywood commented Nov 18, 2025 •

edited

Loading

mafredri Nov 18, 2025 •

edited

Loading