Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

@bpmct
Copy link
Member

@bpmct bpmct commented Sep 13, 2021

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2021

✨ Coder.com for PR #601 deployed! It will be updated on every commit.

@bpmct bpmct requested a review from BrunoQuaresma September 14, 2021 00:35
@bpmct bpmct marked this pull request as ready for review September 14, 2021 00:35
- name: Install node_modules
run: yarn install
- name: Check docs
run: yarn ts-node ./product/coder.com/site/scripts/checkDocs.ts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it's a little clearer to use yarn run ts-node because people less familiar with Node might not be familiar with this behavior.

I'd also suggest putting this at the end of the build (after comment credentials) so that people can see the link to the preview. Otherwise, people won't be able to easily inspect the deployment (needed if you want to open the Vercel console and watch the function logs while you bring up the docs site)

Copy link
Contributor

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bpmct bpmct merged commit 4165d31 into main Sep 14, 2021
@bpmct bpmct deleted the bpmct/detect-docs-404 branch September 14, 2021 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants