Add option to suppress terminal responses#165
Open
assimelha wants to merge 1 commit into
Open
Conversation
diegosouzapw
added a commit
to diegosouzapw/ghostty-web
that referenced
this pull request
May 23, 2026
…eplies Some embedders answer terminal queries (DSR cursor position, device attributes, etc.) at the PTY boundary or server-side mux layer. In those integrations, renderer-generated replies race with or duplicate the server-side replies and — because they are emitted through onData — are indistinguishable from real user input to the PTY. This commit adds an opt-in option: - emitTerminalResponses?: boolean on ITerminalOptions (default: true). Preserves the current behaviour — parser-generated replies flow through onData as before. - When false, the terminal still parses and renders queries normally, but processTerminalResponses() is skipped on each write so onData carries only user-keyboard input. Includes two regression tests covering both option values via \\x1b[5n (DSR "are you there?"). Co-authored-by: assim <hello@assim.me> Inspired-by: coder#165
diegosouzapw
added a commit
to diegosouzapw/ghostty-web
that referenced
this pull request
May 23, 2026
…eplies (#7) Some embedders answer terminal queries (DSR cursor position, device attributes, etc.) at the PTY boundary or server-side mux layer. In those integrations, renderer-generated replies race with or duplicate the server-side replies and — because they are emitted through onData — are indistinguishable from real user input to the PTY. This commit adds an opt-in option: - emitTerminalResponses?: boolean on ITerminalOptions (default: true). Preserves the current behaviour — parser-generated replies flow through onData as before. - When false, the terminal still parses and renders queries normally, but processTerminalResponses() is skipped on each write so onData carries only user-keyboard input. Includes two regression tests covering both option values via \\x1b[5n (DSR "are you there?"). Inspired-by: coder#165 Co-authored-by: assim <hello@assim.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
emitTerminalResponsesterminal option that defaults to the current behavior. When enabled, terminal-generated query replies continue to flow throughonData. When disabled, writes are still parsed and rendered, but parser-generated replies such as DSR responses are not emitted through the sameonDatastream as user keyboard input.Why
Some embedders terminate terminal queries at the PTY boundary or server-side mux layer. In those integrations, renderer-generated replies can race with or duplicate server-side replies, and because they are emitted through
onData, they are indistinguishable from user input to the PTY. This option lets those embedders keeponDatauser-input-only while preserving the existing default behavior for browser-managed PTY integrations.Validation
bun run typecheckbun run fmtbun run lintbun run build:wasmbun test lib/terminal.test.tsgit diff --check