fix: clear text selection when clicking outside canvas #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when users highlighted text and clicked outside the terminal canvas (e.g., on the page background), the selection would persist indefinitely. This was confusing as there was no visual feedback that the selection was still active. This fix adds a document-level click event listener that detects clicks outside the canvas and automatically clears the selection. The listener is properly cleaned up in the dispose() method to prevent memory leaks. Changes: - Added boundClickHandler to track document click listener - Implemented click-outside detection using canvas.contains() - Added proper cleanup in dispose() method - Added test case for click-outside behavior The fix maintains the existing behavior where clicking ON the canvas starts a new selection (which already cleared the previous selection).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.