fix(demo): improve terminal resizing to fit container #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add overflow: hidden and position: relative to #terminal container so the container constrains the canvas size rather than expanding to fit it - Call fitAddon.observeResize() for automatic resize on container changes - Use term.onResize event to notify PTY of dimension changes (works with both observeResize and manual fit calls) - Keep window resize handler for browsers that don't trigger ResizeObserver on window resize This ensures the terminal properly sizes itself to fill the container on initial load and responds to container/window size changes. fix: expose renderer publicly for FitAddon to access FitAddon.proposeDimensions() was returning undefined because it couldn't access the terminal's renderer to get font metrics. The renderer was private, so FitAddon couldn't calculate the correct terminal dimensions. Changes: - Make Terminal.renderer public so FitAddon can access getMetrics() - Add observeResize() call to demo/index.html - Make initTerminal async and await term.open() in demo/index.html - Update demo/bin/demo.js CSS to use absolute positioning for #terminal The root cause was that FitAddon needs renderer.getMetrics() to calculate how many cols/rows fit in the container, but the renderer field was private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.