Demo: Unify HTTP/WebSocket server for reverse proxy compatibility #74
Conversation
|
fmt is my fault on |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // WebSocket server attached to HTTP server (same port) | ||
| const wss = new WebSocketServer({ noServer: true }); | ||
|
|
||
| // Handle HTTP upgrade for WebSocket connections | ||
| httpServer.on('upgrade', (req, socket, head) => { |
There was a problem hiding this comment.
The WebSocket server is now attached to httpServer via noServer/on('upgrade'), but in --dev mode we never call httpServer.listen (we start Vite instead), so no upgrade requests reach this handler and the PTY WebSocket never opens. Running node demo/bin/demo.js --dev leaves the demo stuck at “Connecting…” because the WS endpoint is unreachable. The WSS needs to be wired into the dev server or keep its own listener to keep dev mode usable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Ah, that may actually be true @kylecarbs changing PR back to DRAFT, apols!
2 participants
This changes the demo server to expose the http and websocket services under the same port, so we can easily expose it using ngrok, nginx etc.