Rename --script flag to --sh and use sh from PATH#36
Merged
Conversation
- Rename --script flag to --sh for consistency with other flags - Remove -s shorthand to match --js and --js-file (no shorthand) - Change shell execution to use 'sh' from PATH instead of $SHELL - Update all documentation and help text - Update conflicts_with clauses in clap args Co-authored-by: ammario <7416144+ammario@users.noreply.github.com>
Co-authored-by: ammario <7416144+ammario@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
--scriptflag to--shand removes the-sshorthand for consistency with the--jsand--js-fileflags.Changes
--script→--shwith no shorthand (consistent with--jsand--js-file)shfrom PATH instead of$SHELLenvironment variableconflicts_withclauses in clap argumentsTesting
✅ All unit tests pass
✅ All script integration tests pass
✅ Manual testing of flag functionality confirmed
✅ Conflict testing between
--shand--jsflags verified✅ All CI checks passing