flake: Test_sshConfigProxyCommandEscape/windows_path

[blink-so]

CI Failure Details

CI Run Link: https://github.com/coder/coder/actions/runs/18040492821/job/51337933495
Commit: 0a6ba5d51a02603b5d1ccf9ea3c47f9555ee2a20 - feat: add endpoint to list aibridge interceptions (#19929)
Job: test-go-pg (ubuntu-latest)
Date: 2025-09-26 14:28:38Z

Test Failure

=== FAIL: cli Test_sshConfigProxyCommandEscape/windows_path (0.01s)
    configssh_internal_test.go:180: 
        	Error Trace:	/home/runner/work/coder/coder/cli/configssh_internal_test.go:180
        	Error:      	Received unexpected error:
        	            	exit status 126
        	Test:       	Test_sshConfigProxyCommandEscape/windows_path

Assignment Analysis

Git blame for test function: ./cli/configssh_internal_test.go:141

git blame -L 141,160 ./cli/configssh_internal_test.go
d47a53da82 (Spike Curtis 2025-06-06 16:44:25 +0400) func Test_sshConfigProxyCommandEscape(t *testing.T) {

Last significant modification: Spike Curtis (spike@coder.com)

Root Cause Assessment

• Test Type: CLI unit test for SSH configuration proxy command escaping
• Issue: Process execution failure with exit status 126 (command not executable or permission denied)
• Error Pattern: Clean process error, no data races or panics detected
• Code Impact: The failing commit touches AIBridge functionality, not CLI SSH code, suggesting this is a flaky test unrelated to the code changes

Error Analysis

The test Test_sshConfigProxyCommandEscape/windows_path is testing the escaping of Windows paths in SSH proxy commands. The failure shows exit status 126, which typically indicates:

1. Command not executable - The command/binary cannot be executed
2. Permission denied - Insufficient permissions to execute
3. Path resolution issues - The path to the executable is malformed or incorrect

The test case specifically deals with: C:\\Program Files\\Coder\\bin\\coder.exe

This could be:

• A flaky test due to path escaping logic in different environments
• Platform-specific behavior differences
• Test isolation issues with file system mocking

[spikecurtis]

we tried to fix this once: coder/coder#14233

I think we might be hitting:

But maybe the problem is that there is a separate fork+exec happening in parallel, and while that separate child's exec will close the writable fd, it hasn't exec'ed yet, so it still holds the fd in its forked copy of the fd tables. That would explain the problem.

golang/go#22220 (comment)